-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMap order changes in Python 3.11a3, causing a doctest failure #238
Comments
The failing doctest is:
(Test command was |
musicinmybrain
changed the title
PMap order changes in Python 3.11a3, causing doctest failures
PMap order changes in Python 3.11a3, causing a doctest failure
Jan 13, 2022
Nice find! I'm good with the equality comparison you suggest above even though it's slightly contrived as doc. I haven't found any better way after some very quick research. Please file a PR! |
musicinmybrain
added a commit
to musicinmybrain/pyrsistent
that referenced
this issue
Jan 14, 2022
This keeps them from failing if CPython’s hashing algorithms change, fixing tobgu#238.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
One doctest in
pyrsistent/_pmap.py
fails on Python 3.11a3 because the order ofPMap
entries is not as expected.I suspect this is due to the change from
siphash24
tosiphash13
forstr
/bytes
.I’m happy to submit a PR if you can suggest a preferred approach to dealing with this. One way to make these doctests order-insensitive would be to compare against a
dict
and expect a particular Boolean result, e.g. instead ofwrite
but of course this has slightly less value as documentation.
The text was updated successfully, but these errors were encountered: