Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[themes] Deduplicate colors & icons #17

Closed
tobi-wan-kenobi opened this issue Nov 25, 2016 · 0 comments
Closed

[themes] Deduplicate colors & icons #17

tobi-wan-kenobi opened this issue Nov 25, 2016 · 0 comments
Assignees
Labels
improvement new-theme request for a new theme

Comments

@tobi-wan-kenobi
Copy link
Owner

Right now, each theme has 2 conceptual contents:

  • Icon sets
  • Colors

So, for example, we have powerline-solarized, powerline-gruvbox.

It would be nicer to have a theme that is composed of iconsets and colors. Especially for the iconsets, it could even make sense to have a "nesting" (i.e. use icons of iconset A and fallback to iconset B if icons are missing in A).

@tobi-wan-kenobi tobi-wan-kenobi self-assigned this Nov 25, 2016
tobi-wan-kenobi added a commit that referenced this issue Nov 25, 2016
Add code that allows themes to be merged (i.e. if certain elements are
not present in a theme, another theme can be "overlaid" to add missing
elements).

Effectively, this is used to create the logical concept of an "icon
theme", which is loaded after the main theme. So, the main theme can
define colors, and the icon theme fills in any missing elements
(practically, all the icons in the form of prefixes and suffixes).

Icon sets are defined in a theme using the "icons" directive, which
should be an array.

see #17
@tobi-wan-kenobi tobi-wan-kenobi added the new-theme request for a new theme label Nov 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement new-theme request for a new theme
Projects
None yet
Development

No branches or pull requests

1 participant