Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix facebook feed #19

Merged
merged 3 commits into from
Sep 28, 2022
Merged

Fix facebook feed #19

merged 3 commits into from
Sep 28, 2022

Conversation

tobiasdalhof
Copy link
Owner

currently blocked by #15

closes #17

@netlify
Copy link

netlify bot commented Sep 27, 2022

Deploy Preview for zesty-banoffee-a508db ready!

Name Link
🔨 Latest commit 054b21d
🔍 Latest deploy log https://app.netlify.com/sites/zesty-banoffee-a508db/deploys/6333e8a52a9baf00084d1702
😎 Deploy Preview https://deploy-preview-19--zesty-banoffee-a508db.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tobiasdalhof tobiasdalhof merged commit 905bd1f into main Sep 28, 2022
@tobiasdalhof tobiasdalhof deleted the issue-17 branch September 28, 2022 06:25
Copy link

@arfizato arfizato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't work on facebook feed

@@ -14,18 +14,18 @@ const facebook = new Site({
validateUrl: url => url.pathname === '/',
requiredUserConfigKey: UserConfigKey.FacebookHideHomeFeed,
injectCss: `
div[role="feed"] {
#ssrb_feed_start + div {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't work anymore @tobiasdalhof . at least for me it's
div[role="main"]{

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using div[role="main"] seems to work, but it has the unintended side effect of removing the create post form. To address this, we could consider using a list of selectors and prioritize them, with div[role="main"] as the last selector in case others fail

@tobiasdalhof
Copy link
Owner Author

doesn't work on facebook feed

@arfizato I'll open a new PR later

@tobiasdalhof tobiasdalhof mentioned this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Facebook feed
2 participants