TypeError: Cannot call method 'match' of undefined

[peili]

I am getting the following error, once in a while.

Any idea?

/home/meeting/node_modules/ua-parser/js/index.js:15
var m = ua.match(regexp);
^
TypeError: Cannot call method 'match' of undefined
at Array.parser as 0
at Object.parse (/home/meeting/node_modules/ua-parser/js/index.js:53:31)
at IncomingMessage.app.get.callback (/home/meeting/app.js:294:21)
at IncomingMessage.EventEmitter.emit (events.js:115:20)
at IncomingMessage._emitEnd (http.js:366:10)
at HTTPParser.parserOnMessageComplete as onMessageComplete
at Socket.socketOnData as ondata
at TCP.onread (net.js:402:27)

[tobie]

Probably means your UA string… is not a string.

[tobie]

Question here is should we throw a clearer error here, or should we silently convert all input to strings. /cc @shripadk

[peili]

I personally would recommend to convert all input to strings. BOTS usually don't tell their user-agent. So if you convert all input to strings, i think it is more handable and userfriendly for implementing ua-parser in your own applications. Because you don't need to take care of those bots and extra check if user-agent is set.

[tobie]

Fixed in #91 which I'd love your feedback on.