Skip to content
This repository has been archived by the owner on Apr 28, 2022. It is now read-only.

PROGMEM edit is broken #424

Closed
sehraf opened this issue Jul 4, 2019 · 2 comments
Closed

PROGMEM edit is broken #424

sehraf opened this issue Jul 4, 2019 · 2 comments
Assignees
Labels

Comments

@sehraf
Copy link

sehraf commented Jul 4, 2019

There are two entries that add an action for /edit:

server.on("/edit", HTTP_GET, []() {
if (!handleFileRead("/edit.htm")) server.send(404, "text/plain", "FileNotFound");
});

vs
server.on("/edit", HTTP_GET, [&](){
#ifdef USE_HTML_MIN_GZ
server.sendHeader("Content-Encoding", "gzip", true);
server.send_P(200, PSTR("text/html"), edit_htm_gz, edit_htm_gz_len);
#else
if (!handleFileRead(server.uri()))
handleNotFound();
#endif
});

The first one is deprecated as it cannot handle PROGMEM edit.htm and should be removed.
Currently the first entry is used and this resulting in 404.

@toblum toblum self-assigned this Jul 5, 2019
@toblum toblum added the bug label Jul 5, 2019
@toblum
Copy link
Owner

toblum commented Jul 5, 2019

Hi @sehraf,

thank you for reporting. I'll add that in the next version 2.2.5.

Regards
Tobias

@toblum toblum closed this as completed Jul 5, 2019
toblum added a commit that referenced this issue Jul 5, 2019
@toblum
Copy link
Owner

toblum commented Jul 5, 2019

@sehraf I just published the new release: https://github.com/toblum/McLighting/releases/tag/v2.2.5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants