Conversion of strings containing only numbers

[ronron-gh]

When converting from YAML to JSON using deserializeYml(), even if I explicitly specified that the numbers are strings by enclosing them in double quotes, they were converted as numbers (int, float) as shown below. I'm sorry, but I haven't been able to find out the cause yet.

YAML

  yaml:
    str1: "1"
    str2: "1234567890"
    str3: "1234567890a"

YAML to JSON conversion result ( displayed with serializeJsonPretty() )

  "yaml": {
    "str1": 1,               ←intとして変換された
    "str2": 1.23456789e9,    ←floatとして変換された
    "str3": "1234567890a"    ←アルファベットを含んでいれば文字列として変換された
  },

[tobozo]

hi,

thanks for reporting this 👍

the wrong type guessing is probably caused by a poor decision tree.

the failing test:

bool is_string = (end == scalar || *end);

idea: it should set is_string to true when the value of yamlNode->data.scalar.style is one of YAML_SINGLE_QUOTED_SCALAR_STYLE / YAML_DOUBLE_QUOTED_SCALAR_STYLE

            // (...)
            if( is_string && yaml_node_is_bool( yamlNode, &bool_value ) ) {
              is_bool = true;
            }
            if( yamlNode->data.scalar.style == YAML_SINGLE_QUOTED_SCALAR_STYLE
             || yamlNode->data.scalar.style == YAML_DOUBLE_QUOTED_SCALAR_STYLE ) {
              is_string = true;
            }
            switch( nt ) 
            // (...)

[ronron-gh]

Thank you for your response!
I was able to confirm that it works.
I would be happy if you could incorporate it into the next version.

YAML to JSON conversion result

  "yaml": {
    "str1": "1",
    "str2": "1234567890",
    "str3": "1234567890a"
  },

[tobozo]

thanks for testing this, I'll produce a new release soon

[tobozo]

whoops found a bug with ArduinoJSON 6.x so I'll restrict the next release to ArduinoJSON 7.x

more code needs to be migrated as JsonObject::createNestedArray and JsonArray::createNestedObject methods are being deprecated

[ronron-gh]

I get it.

That's tough ^^;

[tobozo]

looks good

integer: 1234567890
quoted_integer: "1234567890"
float: 12.3323
quoted_float: "12.3323"

{
    "integer": 1234567890,
    "quoted_integer": "1234567890",
    "float": 12.3323,
    "quoted_float": "12.3323"
}

[ronron-gh]

Thank you for the commit!

[tobozo]

is it worth trying to handle both ArduinoJson 6.x and 7.x ?