Feature/intermediate fixes #690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR also has inside code from #658 that is required for MapBox to work on iOS. |
mikedotalmond
added a commit
to mikedotalmond/flutter-mapbox-gl
that referenced
this pull request
Sep 23, 2021
Merged
shroff
approved these changes
Oct 9, 2021
|
@AAverin can you address the change requests of shroff so we can this merged? |
|
@felix-ht Yes, I will take a look once I am back from vacation end of next week. |
|
@felix-ht I have reverted unrelated changes in this PR. |
shroff
approved these changes
Oct 24, 2021
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #347
PR makes sure onStyleLoaded callback is invoked even if
didFinishLoadingwas called beforemap#waitForMap.