Feat(presto): transpile explode/posexplode into (cross join) unnest #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah you're fast, I was hoping to get some open source points here 😄 |
vegarsti
approved these changes
Apr 28, 2023
tobymao
reviewed
Apr 28, 2023
tobymao
reviewed
Apr 28, 2023
tobymao
reviewed
Apr 29, 2023
vegarsti
reviewed
Apr 29, 2023
tobymao
reviewed
Apr 30, 2023
| @@ -4713,6 +4713,8 @@ def alias_( | |||
|
|
|||
| if table: | |||
| table_alias = TableAlias(this=alias) | |||
|
|
|||
| exp = exp.copy() | |||
There was a problem hiding this comment.
only copy if expression is an expression, if it's a string, you don't need this
tobymao
approved these changes
Apr 30, 2023
vegarsti
added a commit
to duneanalytics/harmonizer
that referenced
this pull request
May 3, 2023
After tobymao/sqlglot#1501 was merged and released, the transform we're doing is almost redundant. For some reason, it still fails on Postgres, so we can't remove our transform just yet, will make sure that's fixed upstream.
vegarsti
added a commit
to duneanalytics/harmonizer
that referenced
this pull request
May 3, 2023
Follow up to #43. After tobymao/sqlglot#1501, we can now fully remove our version of the explode to unnest transform! 🎉 The previous PR didn't really do anything, I just didn't realize we had to import the preprocess functions that the Presto dialect uses, and put these in our DuneSQL dialect's preprocess functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1495
cc: @vegarsti I included the test cases you've added to the harmonizer repo, adapted appropriately.