Fix(clickhouse): USING, [PRIMARY|FOREIGN] KEY allows unwrapped col list
#1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I.e. both `USING a, b, c` and `USING (a, b, c)` are allowed Although the wrapped variant is a canonical one (see docs)
|
everywhere with wrapped id vars in clickhouse allows unwrapped? your change seems a bit dangerous should you target it just for the using query? |
Yes, as far as I can see in the ClickHouse code. |
|
It looks good.
|
pkit
changed the title
USING allows unwrapped col listUSING, [PRIMARY|FOREIGN] KEY allows unwrapped col list
|
thanks for checking i’ll review and merge tonight. at a wedding today. |
adrianisk
pushed a commit
to adrianisk/sqlglot
that referenced
this pull request
Jun 21, 2023
I.e. both `USING a, b, c` and `USING (a, b, c)` are allowed Although the wrapped variant is a canonical one (see docs) Co-authored-by: Toby Mao <toby.mao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I.e. both
USING a, b, candUSING (a, b, c)are allowedAlthough the wrapped variant is a canonical one (see docs)
https://clickhouse.com/docs/en/sql-reference/statements/select/join#examples
Unwrapped columns and expression lists are allowed in other places too. Will update later.