Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support parameters in BigQuery / DuckDB #2991

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

r1b
Copy link
Contributor

@r1b r1b commented Feb 19, 2024

  • Add PARAMETER_TOKEN to duckdb dialect
  • Add placeholder_sql to bigquery dialect

Ref: https://cloud.google.com/bigquery/docs/parameterized-queries
Ref: https://duckdb.org/docs/sql/query_syntax/prepared_statements.html#syntax

Copy link
Collaborator

@georgesittas georgesittas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the PR. Will merge and refactor placeholder_sql a bit.

@georgesittas georgesittas merged commit 7c48079 into tobymao:main Feb 19, 2024
5 checks passed
@r1b r1b deleted the feat/bq-ddb-params branch February 19, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants