-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchornous ADC API #471
Synchornous ADC API #471
Conversation
|
That would be great, thank you! |
bors r+ |
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
Pull Request Overview
This PR adds a Synchornous ADC API, which includes:
Alongside the API, this PR adds a fake driver (and unit tests for it) for testing the API.
Testing Strategy
This pull request was tested using unit tests made specifically for this API and fake driver.
TODO or Help Wanted
This pull request still needs feedback / code review.
Tests needed for get_resolution_bits() and get_reference_voltage_mv().
Another PR will follow up with the implementation and tests for continuous sampling.