Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchornous ADC API #471

Merged
merged 9 commits into from
May 17, 2023
Merged

Synchornous ADC API #471

merged 9 commits into from
May 17, 2023

Conversation

AnneOnciulescu
Copy link
Contributor

@AnneOnciulescu AnneOnciulescu commented May 9, 2023

Pull Request Overview

This PR adds a Synchornous ADC API, which includes:

  • function for checking the existence of the driver
  • functions for initating reading of a sample, registering and unregistering a listener
  • function for synchronous sample readings
  • unit tests

Alongside the API, this PR adds a fake driver (and unit tests for it) for testing the API.

Testing Strategy

This pull request was tested using unit tests made specifically for this API and fake driver.

TODO or Help Wanted

This pull request still needs feedback / code review.
Tests needed for get_resolution_bits() and get_reference_voltage_mv().
Another PR will follow up with the implementation and tests for continuous sampling.

@jrvanwhy
Copy link
Collaborator

TODO or Help Wanted

This pull request still needs feedback / code review. Tests needed for get_resolution_bits() and get_reference_voltage_mv(). Another PR will follow up with the implementation and tests for continuous sampling.

get_resolution_bits() and get_reference_voltage_mv() are so simple I don't feel that tests are necessary. I'm happy to merge this as-is if you are okay with me doing so.

@AnneOnciulescu
Copy link
Contributor Author

TODO or Help Wanted

This pull request still needs feedback / code review. Tests needed for get_resolution_bits() and get_reference_voltage_mv(). Another PR will follow up with the implementation and tests for continuous sampling.

get_resolution_bits() and get_reference_voltage_mv() are so simple I don't feel that tests are necessary. I'm happy to merge this as-is if you are okay with me doing so.

That would be great, thank you!

@jrvanwhy
Copy link
Collaborator

bors r+

@bors
Copy link
Contributor

bors bot commented May 17, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 617b21a into tock:master May 17, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants