Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add undocumented changes to the CHANGELOG #1136

Merged
merged 2 commits into from Aug 2, 2018

Conversation

@alevy
Copy link
Member

commented Jul 26, 2018

Pull Request Overview

This pull request adds documentation of how debug::pancic and load_processes have changed since 1.2

Testing Strategy

Read it with my eyes

TODO or Help Wanted

Am I missing anything? @cmcavity might have noticed other undocumented changes while upgrading Teensy.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.
@bradjc

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2018

Thanks for starting this. Unfortunately it is already out of date (debug::panic needs a reference to the processes array).

@alevy alevy force-pushed the alevy:changelog branch from c57181e to 97e549e Jul 27, 2018

@alevy

This comment has been minimized.

Copy link
Member Author

commented Jul 27, 2018

@bradjc fixed.

@alevy alevy requested review from ppannuto and bradjc Jul 31, 2018

@bradjc bradjc referenced this pull request Jul 31, 2018

Closed

Tracking: Make Tock Architecture Agnostic #985

9 of 9 tasks complete
@ppannuto
Copy link
Member

left a comment

bors r+

I think this captures what has been merged so far

bors bot added a commit that referenced this pull request Aug 2, 2018

Merge #1136
1136: Add undocumented changes to the CHANGELOG r=ppannuto a=alevy

### Pull Request Overview

This pull request adds documentation of how `debug::pancic` and `load_processes` have changed since 1.2

### Testing Strategy

Read it with my eyes

### TODO or Help Wanted

Am I missing anything? @cmcavity might have noticed other undocumented changes while upgrading Teensy.

### Documentation Updated

- [X] Updated the relevant files in `/docs`, or no updates are required.

### Formatting

- [X] Ran `make formatall`.


Co-authored-by: Amit Aryeh Levy <amit@amitlevy.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2018

@bors bors bot merged commit 97e549e into tock:master Aug 2, 2018

3 checks passed

bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.