Add a command line argument (--openocd-cmd) to allow callers to control what OpenOCD binary tockloader will invoke.
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trol what OpenOCD binary tockloader will invoke. Some boards (such as the nrf52840dk) can only be programmed by recent versions of OpenOCD. This change allows users to install a newer OpenOCD version locally (rather than system-wide) and use that OpenOCD version with tockloader. Example invocation: tockloader flash --address 0x00000 --openocd --openocd-cmd "$HOME/openocd/install/bin/openocd" --board nrf52dk target/thumbv7em-none-eabi/release/nrf52840dk.bin Open questions for reviewers: 1. Should this be its own flag (current implementation) or a parameter inside openocd_options? 2. Should I try to provide this for JLinkExe as well? I don't have a copy of JLinkExe to test with.
This was referenced Feb 13, 2020
bradjc
approved these changes
Feb 13, 2020
|
I think a separate option for this makes sense. I think we can add this for jlink if someone needs it in the future. But right now the change would conflict with an open PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some boards (such as the nrf52840dk) can only be programmed by recent versions of OpenOCD. This change allows users to install a newer OpenOCD version locally (rather than system-wide) and use that OpenOCD version with tockloader.
Example invocation:
tockloader flash --address 0x00000 --openocd --openocd-cmd "$HOME/openocd/install/bin/openocd" --board nrf52dk target/thumbv7em-none-eabi/release/nrf52840dk.binOpen questions for reviewers: