Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NuGet packages to 1.1 and lower NETStandard to 1.5 #36

Closed
dustinmoris opened this issue Feb 24, 2017 · 2 comments
Closed

Update NuGet packages to 1.1 and lower NETStandard to 1.5 #36

dustinmoris opened this issue Feb 24, 2017 · 2 comments

Comments

@dustinmoris
Copy link

Hi, I saw that RazorLight targets NETStandard 1.6 and this is due to some dependencies that it has. When you upgrade the .NET dependencies from 1.0 to 1.1 then you could lower the NETStandard to 1.5, because unfortunately Microsoft.AspNetCore.Razor.Runtime doesn't target anything lower, otherwise you could have gone as low as 1.3 which would have been ideal.

@toddams
Copy link
Owner

toddams commented Feb 25, 2017

Good point!
When I started developing this Library - NETStandard 1.6 was covered by .NET 4.6.2, but since then situation has changed.

@toddams
Copy link
Owner

toddams commented Apr 2, 2017

Seems like we can't lower NetStandard because of Microsoft.Extensions.DependencyModel package that is used to discover assembly dependencies while building a template.

It is possible to use it on NetStandard1.3, but it does not have all the required API
You can take a look on it's limitations here (https://github.com/dotnet/core-setup/blob/master/src/Microsoft.Extensions.DependencyModel/DependencyContext.cs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants