New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add --recursive flag to enable env-var nesting #253
Open
nkrul
wants to merge
4
commits into
toddbluhm:master
Choose a base branch
from
kncept:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Look like this matches an existing feature request: #97 |
Also possibly #122 |
awesome to see this supported out of the box 🎉 |
nkrul
changed the title
Add --recursive flag to enable env-var nesting
feat: Add --recursive flag to enable env-var nesting
Mar 11, 2021
@toddbluhm Hello! It would be great if you could merge it. Variable expansion is essential for most complex projects |
this would be really useful.... |
@toddbluhm - back to a project where this would be really useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a command line
--recursive
option.This will reprocess the env file to fill in any ${variables} there may be.
eg:
will resolve VAL2 to
Hello There
It's not order dependent, as long as it's in the file
It's all done in a single pass.
Also made
$var
and${var}
both workAlso fixed a return type bug (process.kill can return a boolean in my version of node)
This has been tested on a real project with a file:/ dependency include;