feat: add support for parameter expansion #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpohlmeyer
commented
Feb 2, 2022
| return str.replace(/(?<!\\)\$[a-zA-Z0-9_]+/g, varName => { | ||
| const varValue = envs[varName.slice(1)] | ||
| return varValue === undefined ? varName : varValue | ||
| return str.replace(/(?<!\\)\$\{?([a-zA-Z0-9_]+)\}?/g, (_, varName: string) => { |
There was a problem hiding this comment.
The current implementation does not check, if the pattern is contained in a string. That would make the regex way more complex.
Currently something like env-cmd -x ${WHO} would also be expanded. I don’t think that is a big deal, but if so we could use something like ((?<="[^"]*)\${([a-zA-Z0-9_]+)}(?=[^"]*")|(?<!\\)\$([a-zA-Z0-9_]+)).
Comment on lines
+92
to
+93
| process.kill(process.pid, signal) | ||
| return |
There was a problem hiding this comment.
linting was failing for me on this one, because process.kill seems to return a boolean, but the function expects the return value to be void.
|
|
||
| it('should replace environment variables in args', (): void => { | ||
| // eslint-disable-next-line no-template-curly-in-string |
There was a problem hiding this comment.
I needed to disable the rule for this line, otherwise I could not commit my test string.
|
Think I submitted something similar in #253 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for parameter expansions in strings. For example:
and
{ "script": { "hello": "env-cmd -x echo \"Hello ${WHO}!\"" } }Closes #341