Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required params for game_diff endpoint don't match query_params (case sensitivity) #31

Closed
toddrob99 opened this issue Nov 26, 2019 · 0 comments · Fixed by #36
Closed

Required params for game_diff endpoint don't match query_params (case sensitivity) #31

toddrob99 opened this issue Nov 26, 2019 · 0 comments · Fixed by #36
Assignees
@toddrob99
Labels
bug Something isn't working

Comments

@toddrob99
Copy link
Owner

Query params are startTimecode and endTimecode with lower case c, but required params are listed as startTimeCode and endTimeCode with upper case C.

The API accepts either way, but the wrapper does not make the API call, because it discards unrecognized params if upper case C is used, and fails required param check if lower case c is used.

Use force=True for calls to game_diff endpoint until fix is released.
@toddrob99 toddrob99 added the bug Something isn't working label Nov 26, 2019
@toddrob99 toddrob99 self-assigned this Nov 26, 2019
toddrob99 added a commit that referenced this issue Nov 26, 2019
@toddrob99
Fix game_diff endpoint config #31
172d0c5
@toddrob99 toddrob99 linked a pull request Mar 19, 2020 that will close this issue
v0.1.6 #36
Merged
toddrob99 added a commit that referenced this issue Mar 19, 2020
@toddrob99
Merge pull request #36 from toddrob99/develop
670afdf 
v0.1.6
FIX: Required params for game_diff endpoint don't match query_params (case sensitivity) #31
NEW: Added batter 2b, 3b, hr, sb to box score data (but not formatted box score) and refactored box score code (thanks @rogerhcheng)
NEW: Wiki added to GitHub, documentation removed from source code including README
NEW: GitHub Sponsors button added to repository
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@toddrob99 toddrob99

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v0.1.6 toddrob99/MLB-StatsAPI
1 participant
@toddrob99