Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the server process-id to the MOO #5

Closed
wants to merge 3 commits into from
Closed

Provide the server process-id to the MOO #5

wants to merge 3 commits into from

Conversation

tvdijen
Copy link
Contributor

@tvdijen tvdijen commented Nov 2, 2016

No description provided.

@toddsundsted
Copy link
Owner

Have you considered making making this a [wizardly] builtin function instead of a property on the system object?

The advantage of a builtin is it does not imply the value is writeable/changeable, whereas properties are. The change would require roughly the same amount of code and would fit nicely in server.cc.

@tvdijen
Copy link
Contributor Author

tvdijen commented Nov 7, 2016

Hmm, yeah that's probably a better idea... I wonder why I didn't come up with that!

@toddsundsted
Copy link
Owner

This looks great! To keep the history clean, can you rewrite these three commits into a single commit and I will merge into into the master branch. Thank you!

@toddsundsted
Copy link
Owner

toddsundsted commented Nov 7, 2016

An update to the documentation would be awesome, as well, but I handle that part.

@tvdijen
Copy link
Contributor Author

tvdijen commented Nov 7, 2016

I don't think that's possible with the online GUI here on Github.. The only way I can think of is to create a new pull-request based on the last commit..

@toddsundsted
Copy link
Owner

You'd have to rewrite your git commit history and then force push to the branch, but I'm fine with you closing this PR and opening another on another branch. Thanks!

@tvdijen
Copy link
Contributor Author

tvdijen commented Nov 7, 2016

Note to self; learn more about git... For now, the change is in #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants