Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use shebang #!/usr/bin/env bash #418

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hyperupcall
Copy link
Contributor

Before submitting a pull request, please make sure the following is done:

  • Fork the repository and create your branch from master.
  • If you've added code that should be tested, add tests!
  • Ensure the test suite passes.
  • Format your code with ShellCheck.
  • Include a human-readable description of what the pull request is trying to accomplish.
  • Steps for the reviewer(s) on how they can manually QA the changes.
  • Have a fixes #XX reference to the issue that this pull request fixes.

This updates the shebang to #/usr/bin/env bash. It makes it compatible with not only FreeBSD and friends, but also NixOS.

QA'ing changes

make test

Fixes #385

Copy link
Member

@karbassi karbassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A clean PR! If the tests all pass, then we can merge it.

@inkarkat Do you see any issues with this change?

@inkarkat
Copy link
Member

@karbassi Welcome back; it's good to hear from you again.

I don't see any problems, but would suggest that we work on the backlog of PRs first. Especially my #405 has been waiting for your approval for a long time, and touches many files. If you attack the PRs latest first, that'll only cause merge conflicts.

@hyperupcall
Copy link
Contributor Author

hyperupcall commented Sep 30, 2024

@inkarkat @karbassi 👋 I have updated this (any my other PRs) against the latest merges to HEAD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shell scripts in tests have the path #! /bin/bash hardwired
3 participants