Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove null type in hooks #1955

Merged
merged 12 commits into from
Apr 17, 2023
Merged

Conversation

himself65
Copy link
Contributor

No description provided.

@himself65 himself65 temporarily deployed to development April 14, 2023 22:30 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 14, 2023 22:30 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 14, 2023 22:30 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Apr 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 17, 2023 3:02am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2023 3:02am

@himself65 himself65 temporarily deployed to development April 14, 2023 22:30 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 14, 2023 22:30 — with GitHub Actions Inactive
@himself65 himself65 changed the title refactor: remove null in hooks refactor: remove null type in hooks Apr 14, 2023
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 14, 2023 22:33 Inactive
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: +0.02 🎉

Comparison is base (4cb6b8f) 75.40% compared to head (3db0f83) 75.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1955      +/-   ##
==========================================
+ Coverage   75.40%   75.43%   +0.02%     
==========================================
  Files         276      276              
  Lines        5380     5369      -11     
  Branches     1052     1036      -16     
==========================================
- Hits         4057     4050       -7     
- Misses       1083     1086       +3     
+ Partials      240      233       -7     
Flag Coverage Δ
e2etest 74.76% <90.90%> (+0.05%) ⬆️
storybook-test 50.63% <ø> (ø)
unittest 45.52% <52.38%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...components/affine/pinboard/pinboard-menu/index.tsx 90.32% <ø> (ø)
...mponents/affine/pinboard/pinboard-render/index.tsx 79.48% <ø> (ø)
...pace-setting-detail/panel/general/delete/index.tsx 84.61% <ø> (ø)
...e/workspace-setting-detail/panel/general/index.tsx 50.00% <ø> (ø)
...fine/workspace-setting-detail/panel/sync/index.tsx 20.00% <ø> (ø)
...uite/workspace-header/editor-mode-switch/index.tsx 78.57% <0.00%> (ø)
...c/components/blocksuite/workspace-header/index.tsx 79.16% <0.00%> (ø)
apps/web/src/components/page-detail-editor.tsx 80.95% <0.00%> (ø)
.../src/components/pure/quick-search-modal/Footer.tsx 88.88% <ø> (ø)
...nents/pure/quick-search-modal/PublishedResults.tsx 7.69% <0.00%> (ø)
... and 34 more

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@himself65 himself65 temporarily deployed to development April 14, 2023 22:33 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 14, 2023 22:33 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 14, 2023 22:33 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 14, 2023 22:33 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 14, 2023 22:33 — with GitHub Actions Inactive
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 14, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3db0f83
Status: ✅  Deploy successful!
Preview URL: https://d19cf0c0.affine.pages.dev
Branch Preview URL: https://himself65-0414-remove-null.affine.pages.dev

View logs

@vercel vercel bot temporarily deployed to Preview – affine-preview April 14, 2023 22:36 Inactive
@perfsee
Copy link

perfsee bot commented Apr 14, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …4-remove-null                 +/- ##
===================================================================
> Bundle              4.27 MB        4.27 MB      -686 B(-0.02%)   
> Initial JS          1.89 MB        1.89 MB      -603 B(-0.03%)   
= Initial CSS         3.13 kB        3.13 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   41             41                       
= Chunks                   39             39                       
= Packages                162            162                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …4-remove-null                 +/- ##
===================================================================
> Bundle              4.17 MB        4.17 MB      -686 B(-0.02%)   
> Initial JS          1.79 MB        1.79 MB      -603 B(-0.03%)   
= Initial CSS         3.13 kB        3.13 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   39             39                       
= Chunks                   37             37                       
= Packages                162            162                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …4-remove-null                 +/- ##
===================================================================
= Bundle              16.7 kB        16.7 kB                       
= Initial JS          16.7 kB        16.7 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@himself65 himself65 temporarily deployed to development April 14, 2023 22:45 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 14, 2023 22:45 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 14, 2023 22:45 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 14, 2023 22:45 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 14, 2023 22:45 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 14, 2023 22:48 Inactive
@himself65 himself65 temporarily deployed to development April 14, 2023 22:48 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 17, 2023 01:56 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 17, 2023 01:59 Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 01:59 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 01:59 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 01:59 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 01:59 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 01:59 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 02:01 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 17, 2023 02:03 Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 02:05 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 02:05 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 02:05 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 02:05 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 17, 2023 02:05 Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 02:26 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 02:26 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 02:26 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 02:26 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 02:26 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 02:28 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 02:30 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 02:30 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 02:30 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 02:30 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 17, 2023 02:32 Inactive
@himself65 himself65 merged commit 3d70a36 into master Apr 17, 2023
@himself65 himself65 deleted the himself65/0414-remove-null branch April 17, 2023 02:36
@vercel vercel bot temporarily deployed to Preview – affine-preview April 17, 2023 03:02 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant