Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve disable legacy cloud #2041

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Apr 20, 2023

No description provided.

@JimmFly JimmFly requested a review from himself65 April 20, 2023 03:48
@JimmFly JimmFly temporarily deployed to development April 20, 2023 03:48 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 20, 2023 03:48 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Apr 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 20, 2023 3:55am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2023 3:55am

@JimmFly JimmFly temporarily deployed to development April 20, 2023 03:48 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 20, 2023 03:48 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 20, 2023 03:48 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 20, 2023 03:48 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 20, 2023 03:50 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 20, 2023 03:51 Inactive
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage: 53.57% and project coverage change: -0.10 ⚠️

Comparison is base (9f33e73) 76.41% compared to head (02c3f83) 76.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2041      +/-   ##
==========================================
- Coverage   76.41%   76.31%   -0.10%     
==========================================
  Files         290      292       +2     
  Lines        5829     5843      +14     
  Branches     1069     1063       -6     
==========================================
+ Hits         4454     4459       +5     
- Misses       1136     1144       +8     
- Partials      239      240       +1     
Flag Coverage Δ
e2etest 74.32% <59.09%> (-0.10%) ⬇️
server-test 90.78% <ø> (ø)
storybook-test 50.63% <ø> (ø)
unittest 45.42% <32.14%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/affine/tmp-disable-affine-cloud-modal/index.tsx 25.00% <25.00%> (ø)
...space-setting-detail/panel/collaboration/index.tsx 55.88% <50.00%> (-1.70%) ⬇️
...e/workspace-setting-detail/panel/publish/index.tsx 78.12% <50.00%> (-2.53%) ⬇️
...src/components/pure/workspace-slider-bar/index.tsx 90.69% <60.00%> (-4.55%) ⬇️
...nts/affine/tmp-disable-affine-cloud-modal/style.ts 71.42% <71.42%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 02c3f83
Status: ✅  Deploy successful!
Preview URL: https://90fdba87.affine.pages.dev
Branch Preview URL: https://chore-tmp-disable-affine-clo.affine.pages.dev

View logs

@JimmFly JimmFly temporarily deployed to development April 20, 2023 03:54 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 20, 2023 03:54 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 20, 2023 03:54 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 20, 2023 03:54 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 20, 2023 03:55 Inactive
@perfsee
Copy link

perfsee bot commented Apr 20, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …-affine-cloud                 +/- ##
===================================================================
< Bundle              4.27 MB        4.27 MB     +1.3 kB(+0.03%)   
< Initial JS          1.89 MB         1.9 MB     +1.3 kB(+0.07%)   
= Initial CSS         3.13 kB        3.13 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   41             41                       
= Chunks                   39             39                       
= Packages                162            162                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …-affine-cloud                 +/- ##
===================================================================
< Bundle              4.17 MB        4.17 MB     +1.3 kB(+0.03%)   
< Initial JS          1.79 MB        1.79 MB     +1.3 kB(+0.07%)   
= Initial CSS         3.13 kB        3.13 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   39             39                       
= Chunks                   37             37                       
= Packages                162            162                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …-affine-cloud                 +/- ##
===================================================================
= Bundle              16.7 kB        16.7 kB                       
= Initial JS          16.7 kB        16.7 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@himself65
Copy link
Contributor

ignore the coverage for now

@JimmFly JimmFly merged commit 031ab2c into master Apr 20, 2023
@JimmFly JimmFly deleted the chore/tmp-disable-affine-cloud branch April 20, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants