-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n): static type on i18n #2225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
app:web
docs
Improvements or additions to documentation
mod:component
mod:i18n
Related to i18n
labels
May 4, 2023
affine-toeverythingBundle maindiff ------------------- Bundle Size Diff -------------------------
@@ EntryPoint: main @@
## master …f65/0504-i18n +/- ##
===================================================================
< Bundle 3.11 MB 3.11 MB +4.04 kB(+0.13%)
< Initial JS 1.86 MB 1.86 MB +2.75 kB(+0.15%)
> Initial CSS 16.8 kB 16.7 kB -2 B(-0.01%)
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 41 41
= Chunks 39 39
= Packages 132 132
= Duplicates 3 3
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files
! Avoid non-minified assets
! Avoid cache wasting
@@ EntryPoint: pages/_app @@
## master …f65/0504-i18n +/- ##
===================================================================
< Bundle 3 MB 3 MB +4.06 kB(+0.14%)
< Initial JS 1.75 MB 1.75 MB +2.76 kB(+0.16%)
> Initial CSS 16.8 kB 16.7 kB -2 B(-0.01%)
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 39 39
= Chunks 37 37
= Packages 132 132
= Duplicates 3 3
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files
! Avoid non-minified assets
! Avoid cache wasting
@@ EntryPoint: pages/_error @@
## master …f65/0504-i18n +/- ##
===================================================================
= Bundle 16.6 kB 16.6 kB
= Initial JS 16.6 kB 16.6 kB
= Initial CSS 0 B 0 B
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 2 2
= Chunks 2 2
= Packages 5 5
= Duplicates 0 0
...and more |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2225 +/- ##
===========================================
- Coverage 69.58% 57.30% -12.29%
===========================================
Files 309 302 -7
Lines 6664 6527 -137
Branches 1093 1075 -18
===========================================
- Hits 4637 3740 -897
- Misses 1830 2621 +791
+ Partials 197 166 -31
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Deploying with Cloudflare Pages
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app:web
docs
Improvements or additions to documentation
mod:component
mod:dev
mod:i18n
Related to i18n
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API:
useTranslation
-->useAFFiNEI18N