Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): static type on i18n #2225

Merged
merged 7 commits into from
May 4, 2023
Merged

feat(i18n): static type on i18n #2225

merged 7 commits into from
May 4, 2023

Conversation

himself65
Copy link
Contributor

@himself65 himself65 commented May 4, 2023

API: useTranslation --> useAFFiNEI18N

@himself65 himself65 requested a review from JimmFly as a code owner May 4, 2023 05:01
@himself65 himself65 temporarily deployed to development May 4, 2023 05:01 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:01 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented May 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2023 5:50am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2023 5:50am

@himself65 himself65 temporarily deployed to development May 4, 2023 05:01 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:01 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:01 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:01 — with GitHub Actions Inactive
@github-actions github-actions bot added app:web docs Improvements or additions to documentation mod:component mod:i18n Related to i18n labels May 4, 2023
@himself65 himself65 temporarily deployed to development May 4, 2023 05:05 — with GitHub Actions Inactive
@perfsee
Copy link

perfsee bot commented May 4, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …f65/0504-i18n                 +/- ##
===================================================================
< Bundle              3.11 MB        3.11 MB    +4.04 kB(+0.13%)   
< Initial JS          1.86 MB        1.86 MB    +2.75 kB(+0.15%)   
> Initial CSS         16.8 kB        16.7 kB        -2 B(-0.01%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   41             41                       
= Chunks                   39             39                       
= Packages                132            132                       
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …f65/0504-i18n                 +/- ##
===================================================================
< Bundle                 3 MB           3 MB    +4.06 kB(+0.14%)   
< Initial JS          1.75 MB        1.75 MB    +2.76 kB(+0.16%)   
> Initial CSS         16.8 kB        16.7 kB        -2 B(-0.01%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   39             39                       
= Chunks                   37             37                       
= Packages                132            132                       
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …f65/0504-i18n                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-preview May 4, 2023 05:05 Inactive
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage: 40.65% and project coverage change: -12.29 ⚠️

Comparison is base (66c3b09) 69.58% compared to head (ae1f941) 57.30%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2225       +/-   ##
===========================================
- Coverage   69.58%   57.30%   -12.29%     
===========================================
  Files         309      302        -7     
  Lines        6664     6527      -137     
  Branches     1093     1075       -18     
===========================================
- Hits         4637     3740      -897     
- Misses       1830     2621      +791     
+ Partials      197      166       -31     
Flag Coverage Δ
e2etest 44.87% <41.50%> (-22.70%) ⬇️
server-test 73.14% <ø> (ø)
storybook-test 49.77% <38.46%> (ø)
unittest 35.54% <1.26%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ponents/affine/enable-affine-cloud-modal/index.tsx 12.50% <0.00%> (-50.00%) ⬇️
...omponents/affine/operation-menu-items/CopyLink.tsx 11.11% <0.00%> (ø)
...fine/operation-menu-items/DisablePublicSharing.tsx 50.00% <0.00%> (ø)
.../components/affine/operation-menu-items/Export.tsx 7.14% <0.00%> (-71.43%) ⬇️
.../components/affine/operation-menu-items/MoveTo.tsx 11.11% <0.00%> (ø)
...ts/affine/pinboard/pinboard-menu/SearchContent.tsx 11.11% <0.00%> (ø)
...components/affine/pinboard/pinboard-menu/index.tsx 20.83% <0.00%> (ø)
...ents/affine/pinboard/pinboard-render/EmptyItem.tsx 33.33% <0.00%> (ø)
...ffine/pinboard/pinboard-render/OperationButton.tsx 2.70% <0.00%> (ø)
...mponents/affine/workspace-setting-detail/index.tsx 4.87% <0.00%> (-75.61%) ⬇️
... and 56 more

... and 89 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 4, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ae1f941
Status: ✅  Deploy successful!
Preview URL: https://4bc3cc69.affine.pages.dev
Branch Preview URL: https://himself65-0504-i18n.affine.pages.dev

View logs

@himself65 himself65 temporarily deployed to development May 4, 2023 05:08 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:08 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:08 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:08 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:08 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:08 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:11 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:18 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:18 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:18 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:18 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:18 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:18 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:20 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:23 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:23 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:23 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:23 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:23 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:27 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:30 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:31 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:31 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:31 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 05:31 — with GitHub Actions Inactive
@himself65 himself65 merged commit 3d43e61 into master May 4, 2023
@himself65 himself65 deleted the himself65/0504-i18n branch May 4, 2023 05:35
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 4, 2023 05:46 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 4, 2023 05:50 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:web docs Improvements or additions to documentation mod:component mod:dev mod:i18n Related to i18n
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants