Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace lang icon and update translation #2281

Merged
merged 10 commits into from
May 9, 2023

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented May 9, 2023

No description provided.

@vercel
Copy link

vercel bot commented May 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2023 3:29pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2023 3:29pm

@JimmFly JimmFly temporarily deployed to development May 9, 2023 07:56 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 07:56 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 07:56 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 07:56 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 07:56 — with GitHub Actions Inactive
@JimmFly JimmFly enabled auto-merge (squash) May 9, 2023 07:56
@JimmFly JimmFly temporarily deployed to development May 9, 2023 07:56 — with GitHub Actions Inactive
@JimmFly JimmFly requested review from pengx17 and lawvs May 9, 2023 07:56
@JimmFly JimmFly temporarily deployed to development May 9, 2023 07:59 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 9, 2023 07:59 Inactive
@perfsee
Copy link

perfsee bot commented May 9, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …ace-lang-icon                 +/- ##
===================================================================
< Bundle              3.11 MB        3.16 MB    +49.4 kB(+1.59%)   
< Initial JS          1.86 MB        1.88 MB    +17.7 kB(+0.95%)   
< Initial CSS         16.8 kB          21 kB   +4.27 kB(+25.49%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   41             48                  +7   
< Chunks                   39             43                  +4   
< Packages                132            134                  +2   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …ace-lang-icon                 +/- ##
===================================================================
< Bundle                 3 MB        3.04 MB    +39.9 kB(+1.33%)   
< Initial JS          1.75 MB        1.76 MB    +8.23 kB(+0.47%)   
< Initial CSS         16.8 kB          21 kB   +4.27 kB(+25.49%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   39             46                  +7   
< Chunks                   37             41                  +4   
< Packages                132            134                  +2   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …ace-lang-icon                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -24.43 ⚠️

Comparison is base (3c97e01) 71.24% compared to head (cb435e9) 46.82%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2281       +/-   ##
===========================================
- Coverage   71.24%   46.82%   -24.43%     
===========================================
  Files         317      243       -74     
  Lines        7094     5350     -1744     
  Branches     1135      792      -343     
===========================================
- Hits         5054     2505     -2549     
- Misses       1830     2737      +907     
+ Partials      210      108      -102     
Flag Coverage Δ
e2etest ?
server-test 73.14% <ø> (ø)
storybook-test ?
unittest 40.36% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kspace-header/header-right-items/language-menu.tsx 37.50% <ø> (-37.50%) ⬇️
...der/header-right-items/theme-mode-switch/index.tsx 14.28% <0.00%> (-35.72%) ⬇️
packages/i18n/src/resources/index.ts 100.00% <ø> (ø)

... and 224 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JimmFly JimmFly temporarily deployed to development May 9, 2023 08:00 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 08:00 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 08:00 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 08:00 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 08:00 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 08:00 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 08:00 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 08:00 — with GitHub Actions Inactive
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 9, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cb435e9
Status: ✅  Deploy successful!
Preview URL: https://50551b94.affine.pages.dev
Branch Preview URL: https://chore-replace-lang-icon.affine.pages.dev

View logs

@vercel vercel bot temporarily deployed to Preview – affine-storybook May 9, 2023 08:03 Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 08:22 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 08:22 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 15:12 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 15:12 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 15:12 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 15:12 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 15:12 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 15:12 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 15:12 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 9, 2023 15:15 Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 15:18 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 15:18 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 15:18 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 15:18 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 15:18 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 15:18 — with GitHub Actions Inactive
@github-actions github-actions bot added the test label May 9, 2023
@JimmFly JimmFly temporarily deployed to development May 9, 2023 15:20 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 15:22 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 15:22 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 15:22 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 15:22 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 15:22 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 15:22 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 15:22 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 15:22 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 9, 2023 15:25 Inactive
@JimmFly JimmFly merged commit b937c1b into master May 9, 2023
@JimmFly JimmFly deleted the chore/replace-lang-icon branch May 9, 2023 15:27
@vercel vercel bot temporarily deployed to Preview – affine-preview May 9, 2023 15:29 Inactive
@JimmFly JimmFly mentioned this pull request May 11, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants