-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump up eslint-plugin-simple-import-sort version to v12 #5815
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9e7eb56. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #5815 +/- ##
=======================================
Coverage 65.19% 65.19%
=======================================
Files 347 347
Lines 19624 19624
Branches 1649 1649
=======================================
Hits 12793 12793
Misses 6611 6611
Partials 220 220
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9f20a7a
to
54e3e87
Compare
Merge activity
|
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [eslint-plugin-simple-import-sort](https://togithub.com/lydell/eslint-plugin-simple-import-sort) | [`^10.0.0` -> `^12.0.0`](https://renovatebot.com/diffs/npm/eslint-plugin-simple-import-sort/10.0.0/12.0.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/eslint-plugin-simple-import-sort/12.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint-plugin-simple-import-sort/12.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint-plugin-simple-import-sort/10.0.0/12.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint-plugin-simple-import-sort/10.0.0/12.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>lydell/eslint-plugin-simple-import-sort (eslint-plugin-simple-import-sort)</summary> ### [`v12.0.0`](https://togithub.com/lydell/eslint-plugin-simple-import-sort/blob/HEAD/CHANGELOG.md#Version-1200-2024-02-10) [Compare Source](https://togithub.com/lydell/eslint-plugin-simple-import-sort/compare/v11.0.0...v12.0.0) This release removes the support for import assignments added in version 11.0.0: - Turns out it was broken in some cases. - The suggested fix went past my complexity tolerance for such an esoteric feature. - I also learned that they aren’t really imports, and that I don’t understand their semantics well enough to know how sorting them affects your program. If you miss the support for import assignments, I suggest you write your own ESLint rule which moves them out of the way from the actual imports, sorting them or not. ### [`v11.0.0`](https://togithub.com/lydell/eslint-plugin-simple-import-sort/blob/HEAD/CHANGELOG.md#Version-1100-2024-02-08) [Compare Source](https://togithub.com/lydell/eslint-plugin-simple-import-sort/compare/v10.0.0...v11.0.0) This release adds support for TypeScript import assignments (`import A = B.C` and `import A = require("module")`). Thanks to Szabolcs Kurdi ([@​szku01](https://togithub.com/szku01)) and Svyatoslav Zaytsev ([@​MillerSvt](https://togithub.com/MillerSvt))! It’s only a breaking change if you use TypeScript import assignments, and only in the form that you need to autofix your files. In other news, this release adds the `meta` plugin property in preparation for ESLint Flat Config, and avoids the deprecated `context.getSourceCode()` method (while still being backwards compatible). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/toeverything/AFFiNE). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoiY2FuYXJ5In0=-->
54e3e87
to
9e7eb56
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
This PR contains the following updates:
^10.0.0
->^12.0.0
Release Notes
lydell/eslint-plugin-simple-import-sort (eslint-plugin-simple-import-sort)
v12.0.0
Compare Source
This release removes the support for import assignments added in version 11.0.0:
If you miss the support for import assignments, I suggest you write your own ESLint rule which moves them out of the way from the actual imports, sorting them or not.
v11.0.0
Compare Source
This release adds support for TypeScript import assignments (
import A = B.C
andimport A = require("module")
). Thanks to Szabolcs Kurdi (@szku01) and Svyatoslav Zaytsev (@MillerSvt)!It’s only a breaking change if you use TypeScript import assignments, and only in the form that you need to autofix your files.
In other news, this release adds the
meta
plugin property in preparation for ESLint Flat Config, and avoids the deprecatedcontext.getSourceCode()
method (while still being backwards compatible).Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.