Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): polyfill resize-observer for development to avoid error overlay #5943

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Feb 28, 2024

Brought a temporary solution from petyosi/react-virtuoso#875 (comment)

Copy link

graphite-app bot commented Feb 28, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Feb 28, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

nx-cloud bot commented Feb 28, 2024

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.97%. Comparing base (82f21ac) to head (35454c3).

Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #5943       +/-   ##
===========================================
- Coverage   64.05%   43.97%   -20.08%     
===========================================
  Files         364      231      -133     
  Lines       20032     5332    -14700     
  Branches     1714      938      -776     
===========================================
- Hits        12831     2345    -10486     
+ Misses       6982     2799     -4183     
+ Partials      219      188       -31     
Flag Coverage Δ
server-test ?
unittest 43.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Feb 28, 2024

Merge activity

@Brooooooklyn Brooooooklyn force-pushed the 02-28-fix_core_polyfill_resize-observer_for_development_to_avoid_error_overlay branch from 168021f to 35454c3 Compare February 28, 2024 08:18
@graphite-app graphite-app bot merged commit 35454c3 into canary Feb 28, 2024
32 of 35 checks passed
@graphite-app graphite-app bot deleted the 02-28-fix_core_polyfill_resize-observer_for_development_to_avoid_error_overlay branch February 28, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants