-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): replace all notification relies on jotai #6417
refactor(core): replace all notification relies on jotai #6417
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CatsJuice and the rest of your teammates on Graphite |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9127bfa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #6417 +/- ##
==========================================
+ Coverage 61.96% 62.25% +0.29%
==========================================
Files 519 515 -4
Lines 23947 23773 -174
Branches 2300 2257 -43
==========================================
- Hits 14838 14801 -37
+ Misses 8844 8707 -137
Partials 265 265
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c0d9491
to
f80d5e4
Compare
4d092c2
to
354f20c
Compare
f80d5e4
to
8f28040
Compare
Merge activity
|
- remove all notification that implemented with jotai and replaced with new `notify` - Add some notify presets: - `notify.error` - `notify.success` - `notify.warning`
354f20c
to
a4cd51e
Compare
8f28040
to
9127bfa
Compare
notify
notify.error
notify.success
notify.warning