Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): replace all notification relies on jotai #6417

Merged

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Mar 30, 2024

  • remove all notification that implemented with jotai and replaced with new notify
  • Add some notify presets:
    • notify.error
    • notify.success
    • notify.warning

Copy link

graphite-app bot commented Mar 30, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Member Author

CatsJuice commented Mar 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Mar 30, 2024

@CatsJuice CatsJuice marked this pull request as ready for review March 30, 2024 15:31
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 62.25%. Comparing base (a4cd51e) to head (9127bfa).

Files Patch % Lines
...ponent/src/ui/notification/notification-center.tsx 50.00% 3 Missing ⚠️
...pure/workspace-slider-bar/workspace-card/index.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6417      +/-   ##
==========================================
+ Coverage   61.96%   62.25%   +0.29%     
==========================================
  Files         519      515       -4     
  Lines       23947    23773     -174     
  Branches     2300     2257      -43     
==========================================
- Hits        14838    14801      -37     
+ Misses       8844     8707     -137     
  Partials      265      265              
Flag Coverage Δ
server-test 73.91% <ø> (ø)
unittest 38.73% <33.33%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice changed the title refactor(core): replace all notification rely on jotai with ui/notify Pull Request Summary Mar 30, 2024
@CatsJuice CatsJuice changed the title Pull Request Summary refactor(core): replace all notification relies on jotai Mar 30, 2024
@CatsJuice CatsJuice force-pushed the catsjuice/refactor/0330/notification-replacement branch from c0d9491 to f80d5e4 Compare March 30, 2024 15:56
@github-actions github-actions bot added the test Related to test cases label Mar 30, 2024
@CatsJuice CatsJuice self-assigned this Mar 31, 2024
@CatsJuice CatsJuice force-pushed the catsjuice/refactor/0330/notification branch from 4d092c2 to 354f20c Compare April 1, 2024 10:35
@CatsJuice CatsJuice force-pushed the catsjuice/refactor/0330/notification-replacement branch from f80d5e4 to 8f28040 Compare April 1, 2024 10:35
Copy link

graphite-app bot commented Apr 2, 2024

Merge activity

- remove all notification that implemented with jotai and replaced with new `notify`
- Add some notify presets:
  - `notify.error`
  - `notify.success`
  - `notify.warning`
@EYHN EYHN force-pushed the catsjuice/refactor/0330/notification branch from 354f20c to a4cd51e Compare April 2, 2024 03:19
@EYHN EYHN force-pushed the catsjuice/refactor/0330/notification-replacement branch from 8f28040 to 9127bfa Compare April 2, 2024 03:20
@EYHN EYHN changed the base branch from catsjuice/refactor/0330/notification to canary April 2, 2024 03:29
@graphite-app graphite-app bot merged commit 9127bfa into canary Apr 2, 2024
32 checks passed
@graphite-app graphite-app bot deleted the catsjuice/refactor/0330/notification-replacement branch April 2, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app mod:component test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants