Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): unexpected horizontal scrolling after jump to block #6475

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Apr 8, 2024

close TOV-788

Copy link

graphite-app bot commented Apr 8, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Member Author

JimmFly commented Apr 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Apr 8, 2024

@JimmFly JimmFly requested a review from EYHN April 8, 2024 05:48
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.28%. Comparing base (4a93582) to head (a83f49e).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #6475   +/-   ##
=======================================
  Coverage   62.28%   62.28%           
=======================================
  Files         519      519           
  Lines       24048    24048           
  Branches     2275     2275           
=======================================
  Hits        14979    14979           
  Misses       8797     8797           
  Partials      272      272           
Flag Coverage Δ
server-test 73.82% <ø> (ø)
unittest 38.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly changed the title fix: unexpected horizontal scrolling after jump to block fix(core): unexpected horizontal scrolling after jump to block Apr 8, 2024
@JimmFly JimmFly requested review from pengx17 and removed request for EYHN April 8, 2024 06:08
Copy link
Collaborator

@pengx17 pengx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no horizontal scrolling at all - how to reproduce this issue?

@JimmFly
Copy link
Member Author

JimmFly commented Apr 9, 2024

There should be no horizontal scrolling at all - how to reproduce this issue?

First, use the split-view on the client, then focus on the tab on the right, and use quick search to jump to another doc. The automatic scrolling after the jump will move the entire container sideways. @pengx17

@JimmFly JimmFly requested a review from pengx17 April 9, 2024 06:43
Copy link

graphite-app bot commented Apr 9, 2024

Merge activity

@graphite-app graphite-app bot merged commit a83f49e into canary Apr 9, 2024
36 of 40 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0408/fix-side-bar branch April 9, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants