Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add sign in to not found page #6496

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Apr 9, 2024

close AFF-211

Copy link

graphite-app bot commented Apr 9, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Member Author

JimmFly commented Apr 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Apr 9, 2024

@JimmFly JimmFly requested a review from CatsJuice April 9, 2024 08:31
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 62.30%. Comparing base (7d131ee) to head (6ea20e4).

Files Patch % Lines
packages/frontend/component/src/ui/empty/empty.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6496      +/-   ##
==========================================
+ Coverage   62.28%   62.30%   +0.01%     
==========================================
  Files         519      519              
  Lines       24048    24049       +1     
  Branches     2275     2272       -3     
==========================================
+ Hits        14979    14983       +4     
+ Misses       8797     8794       -3     
  Partials      272      272              
Flag Coverage Δ
server-test 73.82% <ø> (ø)
unittest 38.78% <85.71%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly marked this pull request as draft April 9, 2024 08:38
@JimmFly JimmFly requested a review from pengx17 April 9, 2024 09:27
@JimmFly JimmFly marked this pull request as ready for review April 9, 2024 09:46
@JimmFly JimmFly force-pushed the jimmfly/0409/page branch 2 times, most recently from c52e874 to c6755c6 Compare April 10, 2024 04:54
@JimmFly JimmFly requested a review from pengx17 April 10, 2024 04:57
@JimmFly JimmFly requested a review from EYHN April 10, 2024 07:03
Copy link

graphite-app bot commented Apr 10, 2024

Merge activity

@graphite-app graphite-app bot merged commit 6ea20e4 into canary Apr 10, 2024
36 of 40 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0409/page branch April 10, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants