Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add fallback component to member list #6672

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Apr 23, 2024

image

Copy link

graphite-app bot commented Apr 23, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

@JimmFly JimmFly marked this pull request as ready for review April 23, 2024 07:34
Copy link
Member Author

JimmFly commented Apr 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added mod:i18n Related to i18n app:core labels Apr 23, 2024
Copy link

nx-cloud bot commented Apr 23, 2024

@JimmFly JimmFly requested a review from pengx17 April 23, 2024 07:34
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.48%. Comparing base (2a2b1ce) to head (31b284a).

Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #6672       +/-   ##
===========================================
- Coverage   61.04%   39.48%   -21.56%     
===========================================
  Files         574      408      -166     
  Lines       26576     7876    -18700     
  Branches     2309     1325      -984     
===========================================
- Hits        16222     3110    -13112     
+ Misses      10091     4537     -5554     
+ Partials      263      229       -34     
Flag Coverage Δ
server-test ?
unittest 39.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Apr 24, 2024

Merge activity

  • Apr 24, 6:10 AM EDT: pengx17 added this pull request to the Graphite merge queue.
  • Apr 24, 6:20 AM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'E2E Test (1)', 'E2E Test (2)', 'E2E Test (3)', 'E2E Test (4)', 'E2E Test (5)', 'E2E Migration Test', 'Server E2E Test 1/3', 'Server E2E Test 2/3', 'Server E2E Test 3/3', 'Server Desktop E2E Test', 'Desktop Test (ubuntu-latest, linux, x64, x86_64-unknown-linux-gnu, true)').
  • Apr 24, 10:24 PM EDT: EYHN added this pull request to the Graphite merge queue.
  • Apr 24, 10:38 PM EDT: EYHN merged this pull request with the Graphite merge queue.

@EYHN EYHN force-pushed the jimmfly/0423/add-fallback branch from 31303b8 to 31b284a Compare April 25, 2024 02:27
@graphite-app graphite-app bot merged commit 31b284a into canary Apr 25, 2024
33 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0423/add-fallback branch April 25, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants