Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): optimize the shift multi-selection function of doc list #6675

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Apr 23, 2024

close TOV-701

2024-04-24.3.27.35.mov

Copy link

graphite-app bot commented Apr 23, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

@JimmFly JimmFly marked this pull request as ready for review April 23, 2024 11:05
Copy link
Member Author

JimmFly commented Apr 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Apr 23, 2024

@JimmFly JimmFly requested a review from pengx17 April 23, 2024 11:08
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.96%. Comparing base (6525c99) to head (350fec5).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6675      +/-   ##
==========================================
- Coverage   61.04%   60.96%   -0.08%     
==========================================
  Files         574      574              
  Lines       26576    26576              
  Branches     2309     2308       -1     
==========================================
- Hits        16222    16203      -19     
- Misses      10090    10109      +19     
  Partials      264      264              
Flag Coverage Δ
server-test 70.01% <ø> (-0.10%) ⬇️
unittest 39.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the test Related to test cases label Apr 24, 2024
@JimmFly JimmFly force-pushed the jimmfly/0423/multiselect branch 2 times, most recently from 8ae6e8c to 0bc898e Compare April 24, 2024 07:40
Copy link

graphite-app bot commented Apr 24, 2024

Merge activity

@graphite-app graphite-app bot merged commit 350fec5 into canary Apr 24, 2024
32 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0423/multiselect branch April 24, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants