Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): set the right sidebar to display TOC by default #6503

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Apr 10, 2024

2024-04-10.4.59.27.mov

Copy link

graphite-app bot commented Apr 10, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Member Author

JimmFly commented Apr 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Apr 10, 2024

@JimmFly JimmFly requested a review from pengx17 April 10, 2024 09:01
@hwangdev97
Copy link
Member

@zanwei 👀kk

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.59%. Comparing base (9dd4c74) to head (8579ac6).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6503      +/-   ##
==========================================
- Coverage   61.66%   61.59%   -0.08%     
==========================================
  Files         526      526              
  Lines       25877    25877              
  Branches     2327     2326       -1     
==========================================
- Hits        15958    15939      -19     
- Misses       9645     9664      +19     
  Partials      274      274              
Flag Coverage Δ
server-test 71.64% <ø> (-0.11%) ⬇️
unittest 38.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zanwei
Copy link
Member

zanwei commented Apr 10, 2024

LGTM cc @JimmFly

Copy link

graphite-app bot commented Apr 11, 2024

Merge activity

@graphite-app graphite-app bot merged commit 8579ac6 into canary Apr 11, 2024
36 of 40 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0410/toc branch April 11, 2024 10:16
EYHN pushed a commit that referenced this pull request Apr 26, 2024
#6503 does not work with "open in chat".
IMO resetting tab whenever opening right panel does not make too much sense. @zanwei

fix AFF-951
EYHN pushed a commit that referenced this pull request Apr 26, 2024
#6503 does not work with "open in chat".
IMO resetting tab whenever opening right panel does not make too much sense. @zanwei

fix AFF-951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants