Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect mixpanel param #6706

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Apr 26, 2024

No description provided.

Copy link

graphite-app bot commented Apr 26, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

@pengx17 pengx17 marked this pull request as ready for review April 26, 2024 06:38
Copy link
Collaborator Author

pengx17 commented Apr 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Apr 26, 2024

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.78%. Comparing base (850bbee) to head (d015be2).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6706      +/-   ##
==========================================
+ Coverage   64.72%   64.78%   +0.06%     
==========================================
  Files         588      588              
  Lines       27654    27654              
  Branches     2512     2513       +1     
==========================================
+ Hits        17899    17917      +18     
+ Misses       9470     9452      -18     
  Partials      285      285              
Flag Coverage Δ
server-test 74.56% <ø> (+0.09%) ⬆️
unittest 41.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 added the merge label Apr 26, 2024
Copy link

graphite-app bot commented Apr 26, 2024

Merge activity

  • Apr 26, 6:44 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Apr 26, 6:44 AM EDT: pengx17 added this pull request to the Graphite merge queue.
  • Apr 26, 6:56 AM EDT: pengx17 merged this pull request with the Graphite merge queue.

@pengx17 pengx17 force-pushed the 04-26-fix_incorrect_mixpanel_param branch from 2625b67 to d015be2 Compare April 26, 2024 10:45
@graphite-app graphite-app bot merged commit d015be2 into canary Apr 26, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 04-26-fix_incorrect_mixpanel_param branch April 26, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants