Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add private anchor link for sharing #6966

Merged
merged 1 commit into from
May 16, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented May 16, 2024

close AFF-1085

Copy link

graphite-app bot commented May 16, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@JimmFly JimmFly marked this pull request as ready for review May 16, 2024 09:42
@github-actions github-actions bot added mod:i18n Related to i18n app:core labels May 16, 2024
Copy link
Member Author

JimmFly commented May 16, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented May 16, 2024

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.32%. Comparing base (3799b65) to head (10015c5).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #6966   +/-   ##
=======================================
  Coverage   67.32%   67.32%           
=======================================
  Files         583      583           
  Lines       28079    28079           
  Branches     2581     2581           
=======================================
  Hits        18903    18903           
  Misses       8904     8904           
  Partials      272      272           
Flag Coverage Δ
server-test 78.00% <ø> (ø)
unittest 39.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly force-pushed the jimmfly/0516/copy-link branch 2 times, most recently from a97203f to 3d0990e Compare May 16, 2024 12:03
Copy link

graphite-app bot commented May 16, 2024

Merge activity

@graphite-app graphite-app bot merged commit 10015c5 into canary May 16, 2024
33 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0516/copy-link branch May 16, 2024 13:49
EYHN pushed a commit that referenced this pull request May 20, 2024
JimmFly added a commit that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants