Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): selected content should not be activated when executing open in chat #7302

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Jun 21, 2024

Closes: AF-949

Copy link

graphite-app bot commented Jun 21, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

fundon commented Jun 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Jun 21, 2024

@fundon fundon marked this pull request as ready for review June 21, 2024 09:50
@fundon fundon requested a review from L-Sun June 21, 2024 09:51
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 58.42%. Comparing base (cd9205a) to head (8d602d4).

Files Patch % Lines
...src/blocksuite/presets/ai/chat-panel/chat-cards.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7302      +/-   ##
==========================================
- Coverage   58.47%   58.42%   -0.06%     
==========================================
  Files         839      839              
  Lines       36587    36586       -1     
  Branches     3937     3937              
==========================================
- Hits        21394    21375      -19     
- Misses      14899    14917      +18     
  Partials      294      294              
Flag Coverage Δ
server-test 77.71% <ø> (-0.09%) ⬇️
unittest 28.96% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon added the merge label Jun 21, 2024
Copy link

graphite-app bot commented Jun 21, 2024

Merge activity

  • Jun 21, 8:05 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 21, 8:05 AM EDT: fundon added this pull request to the Graphite merge queue.
  • Jun 21, 8:19 AM EDT: fundon merged this pull request with the Graphite merge queue.

@fundon fundon force-pushed the 06_21-fix-should-not-be-activated-when-executing-open-in-chat branch from 83469a9 to 8d602d4 Compare June 21, 2024 12:06
@graphite-app graphite-app bot merged commit 8d602d4 into canary Jun 21, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 06_21-fix-should-not-be-activated-when-executing-open-in-chat branch June 21, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants