Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: text renderer last child margin bottom #7309

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

donteatfriedrice
Copy link
Member

No description provided.

Copy link

graphite-app bot commented Jun 24, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@donteatfriedrice donteatfriedrice requested review from L-Sun and removed request for forehalo, EYHN, CatsJuice and JimmFly June 24, 2024 09:42
Copy link

nx-cloud bot commented Jun 24, 2024

Copy link

graphite-app bot commented Jun 24, 2024

Merge activity

  • Jun 24, 5:43 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 24, 5:57 AM EDT: donteatfriedrice added this pull request to the Graphite merge queue.
  • Jun 24, 6:11 AM EDT: donteatfriedrice merged this pull request with the Graphite merge queue.

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.42%. Comparing base (e92eb33) to head (0918730).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #7309   +/-   ##
=======================================
  Coverage   58.42%   58.42%           
=======================================
  Files         839      839           
  Lines       36586    36586           
  Branches     3937     3937           
=======================================
  Hits        21375    21375           
  Misses      14917    14917           
  Partials      294      294           
Flag Coverage Δ
server-test 77.71% <ø> (ø)
unittest 28.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@donteatfriedrice donteatfriedrice force-pushed the fix/text-renderer-last-child-margin branch from 4cef088 to 0918730 Compare June 24, 2024 09:57
@graphite-app graphite-app bot merged commit 0918730 into canary Jun 24, 2024
32 checks passed
@graphite-app graphite-app bot deleted the fix/text-renderer-last-child-margin branch June 24, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants