Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): adjust ai help island style and behavior, add animation #7310

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Jun 24, 2024

  • Move right-sidebar activeTab state into RightSidebarService
  • Remove styled usage and adjust the UI
  • Fix the issue that ai-button clicking not work when sidebar opened
  • Add an animation if AI-Chat panel hasn't been opened.

CleanShot 2024-06-24 at 18.10.27.gif

Copy link

graphite-app bot commented Jun 24, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Jun 24, 2024

@CatsJuice CatsJuice marked this pull request as ready for review June 24, 2024 10:14
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 58.45%. Comparing base (0918730) to head (b38c466).

Files Patch % Lines
...rc/modules/right-sidebar/entities/right-sidebar.ts 16.66% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7310      +/-   ##
==========================================
- Coverage   58.47%   58.45%   -0.02%     
==========================================
  Files         839      839              
  Lines       36586    36598      +12     
  Branches     3938     3939       +1     
==========================================
+ Hits        21394    21395       +1     
- Misses      14898    14909      +11     
  Partials      294      294              
Flag Coverage Δ
server-test 77.79% <ø> (ø)
unittest 28.95% <16.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Jun 24, 2024

Merge activity

…7310)

- Move right-sidebar activeTab state into `RightSidebarService`
- Remove `styled` usage and adjust the UI
- Fix the issue that ai-button clicking not work when sidebar opened
- Add an animation if AI-Chat panel hasn't been opened.

![CleanShot 2024-06-24 at 18.10.27.gif](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/LakojjjzZNf6ogjOVwKE/14c86fbc-ad4c-44bf-93fe-ca3450db908b.gif)
@EYHN EYHN force-pushed the catsjuice/feat/ai-button-animation branch from f172142 to b38c466 Compare June 24, 2024 14:37
@graphite-app graphite-app bot merged commit b38c466 into canary Jun 24, 2024
32 checks passed
@graphite-app graphite-app bot deleted the catsjuice/feat/ai-button-animation branch June 24, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants