fix(edgeless): bind shortcuts in toolbar should dispose when tool disconnected #7329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Your org has enabled the Graphite merge queue for merging into masterAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CatsJuice and the rest of your teammates on |
This was referenced Jun 15, 2024
CatsJuice
force-pushed
the
catsjuice/fix/edgeless-toolbar-shortcuts-dispose
branch
from
de3c8d8
to
085c4a0
Compare
Saul-Mirone
approved these changes
Jun 16, 2024
CatsJuice
force-pushed
the
catsjuice/fix/edgeless-toolbar-shortcuts-dispose
branch
from
085c4a0
to
d29b0f4
Compare
Merge activity
|
…connected (#7329) Tool buttons in edgeless toolbar may destroy and re-mount, so it's better to dispose the hot-key events when it disconnected.
Saul-Mirone
force-pushed
the
catsjuice/fix/edgeless-toolbar-shortcuts-dispose
branch
from
d29b0f4
to
5d6bac6
Compare
graphite-app
bot
deleted the
catsjuice/fix/edgeless-toolbar-shortcuts-dispose
branch
EYHN
added a commit
to toeverything/AFFiNE
that referenced
this pull request
Jun 17, 2024
## Features - toeverything/blocksuite#7340 @pengx17 - toeverything/blocksuite#7334 @EYHN - toeverything/blocksuite#7339 @donteatfriedrice - toeverything/blocksuite#7328 @zzj3720 - toeverything/blocksuite#7324 @Flrande - toeverything/blocksuite#7297 @pengx17 - toeverything/blocksuite#7318 @CatsJuice ## Bugfix - toeverything/blocksuite#7343 @Saul-Mirone - toeverything/blocksuite#7345 @donteatfriedrice - toeverything/blocksuite#7341 @donteatfriedrice - toeverything/blocksuite#7342 @zzj3720 - toeverything/blocksuite#7329 @CatsJuice - toeverything/blocksuite#7337 @fundon - toeverything/blocksuite#7333 @fundon - toeverything/blocksuite#7326 @akumatus - toeverything/blocksuite#7325 @Flrande - toeverything/blocksuite#7323 @zzj3720 - toeverything/blocksuite#7312 @golok727 - toeverything/blocksuite#7317 @CatsJuice - toeverything/blocksuite#7319 @akumatus ## Refactor - toeverything/blocksuite#7327 @Flrande - toeverything/blocksuite#7320 @Flrande ## Misc - toeverything/blocksuite#7303 @fundon - toeverything/blocksuite#7321 @Saul-Mirone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tool buttons in edgeless toolbar may destroy and re-mount, so it's better to dispose the hot-key events when it disconnected.