fix: add a 500ms delay time before showing the hover toolbar #7338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Your org has enabled the Graphite merge queue for merging into masterAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
akumatus
changed the title
akumatus
changed the title
akumatus
changed the title
akumatus
force-pushed
the
fix/hover-enter-delay-time
branch
from
eac05aa
to
edb6f97
Compare
akumatus
force-pushed
the
fix/hover-enter-delay-time
branch
from
edb6f97
to
678cf87
Compare
akumatus
force-pushed
the
fix/hover-enter-delay-time
branch
from
678cf87
to
d9ba255
Compare
|
Maybe I can fix it later? @akumatus |
akumatus
force-pushed
the
fix/hover-enter-delay-time
branch
from
d9ba255
to
8dae703
Compare
akumatus
force-pushed
the
fix/hover-enter-delay-time
branch
from
8dae703
to
b85d6b1
Compare
akumatus
force-pushed
the
fix/hover-enter-delay-time
branch
from
b85d6b1
to
91bbd32
Compare
akumatus
force-pushed
the
fix/hover-enter-delay-time
branch
from
91bbd32
to
76434e6
Compare
Thanks for your help! Maybe it's a good chance for me to get familar with lit and hover logic, although there were some egde scenes which took me a lot time to handle. |
Merge activity
|
Saul-Mirone
pushed a commit
that referenced
this pull request
Jun 18, 2024
### What Changed? - Prevents responding to hover state changes if the host element is disconnected from the DOM. - Use current event flag to ignore expired event. - Add a new property `enterDelay` with a value of 500ms to the constructor of the hover controller in link and refernce scenes.
Saul-Mirone
force-pushed
the
fix/hover-enter-delay-time
branch
from
76434e6
to
0f3ad37
Compare
Saul-Mirone
pushed a commit
that referenced
this pull request
Jun 18, 2024
### What Changed? - Prevents responding to hover state changes if the host element is disconnected from the DOM. - Use current event flag to ignore expired event. - Add a new property `enterDelay` with a value of 500ms to the constructor of the hover controller in link and refernce scenes.
Saul-Mirone
force-pushed
the
fix/hover-enter-delay-time
branch
from
0f3ad37
to
ae1fc6e
Compare
Saul-Mirone
pushed a commit
that referenced
this pull request
Jun 18, 2024
### What Changed? - Prevents responding to hover state changes if the host element is disconnected from the DOM. - Use current event flag to ignore expired event. - Add a new property `enterDelay` with a value of 500ms to the constructor of the hover controller in link and refernce scenes.
Saul-Mirone
force-pushed
the
fix/hover-enter-delay-time
branch
from
ae1fc6e
to
a94c82d
Compare
### What Changed? - Prevents responding to hover state changes if the host element is disconnected from the DOM. - Use current event flag to ignore expired event. - Add a new property `enterDelay` with a value of 500ms to the constructor of the hover controller in link and refernce scenes.
Saul-Mirone
force-pushed
the
fix/hover-enter-delay-time
branch
from
a94c82d
to
09c9d5e
Compare
This was referenced Jun 18, 2024
L-Sun
added a commit
to toeverything/AFFiNE
that referenced
this pull request
Jun 18, 2024
## Features - toeverything/blocksuite#7330 @CatsJuice - toeverything/blocksuite#7348 @zzj3720 ## Bugfix - toeverything/blocksuite#7338 @akumatus - toeverything/blocksuite#7353 @Saul-Mirone - toeverything/blocksuite#7351 @lawvs - toeverything/blocksuite#7357 @L-Sun - toeverything/blocksuite#7355 @akumatus ## Misc - toeverything/blocksuite#7352 @L-Sun - toeverything/blocksuite#7349 @pengx17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
enterDelaywith a value of 500ms to the constructor of the hover controller in link and refernce scenes.