fix: ignore composing event in slash menu #7351
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Your org has enabled the Graphite merge queue for merging into masterAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
Could you provide more details explaining the differences before and after the changes? On my device, whether the IME is activated or not, the slash key always inputs '/'. Maybe other IMEs input different characters with the slash key, but we plan to support this case to make it easier to use. |
The slash menu has a query function. This PR mainly fixes the user experience when using IME query. I have updated a comparison video in the PR description. |
Good catch, and it makes sense. |
Merge activity
|
This pull request fixes an issue where the slash menu was not ignoring composing events. Before https://github.com/toeverything/blocksuite/assets/18554747/a5da4c83-3412-4e04-b02e-30971277dc86 After https://github.com/toeverything/blocksuite/assets/18554747/def918aa-2649-4d30-a178-04789fef7cee
L-Sun
force-pushed
the
fix/slash-menu-composing
branch
from
53a1e55
to
5e59b8a
Compare
## Features - toeverything/blocksuite#7330 @CatsJuice - toeverything/blocksuite#7348 @zzj3720 ## Bugfix - toeverything/blocksuite#7338 @akumatus - toeverything/blocksuite#7353 @Saul-Mirone - toeverything/blocksuite#7351 @lawvs - toeverything/blocksuite#7357 @L-Sun - toeverything/blocksuite#7355 @akumatus ## Misc - toeverything/blocksuite#7352 @L-Sun - toeverything/blocksuite#7349 @pengx17
This pull request fixes an issue where the slash menu was not ignoring composing events.
Before
Screen.Recording.2024-06-18.at.03.06.45.mov
After
Screen.Recording.2024-06-18.at.03.06.21.mov