Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(edgeless): optimize double click to enter canvas text edit state under hollow shape #5043

Merged
merged 7 commits into from
Oct 19, 2023
Merged

feat(edgeless): optimize double click to enter canvas text edit state under hollow shape #5043

merged 7 commits into from
Oct 19, 2023

Conversation

donteatfriedrice
Copy link
Member

@donteatfriedrice donteatfriedrice commented Oct 17, 2023 •
edited
Loading

To close #4764

  • Optimize hollow shape hit test
  • Without shape text, stroke and center area can be hit
Screen.Recording.2023-10-18.at.10.59.13.mov
  • With shape text, stroke and text area can be hit
Screen.Recording.2023-10-18.at.10.59.41.mov
  • Text element outside shape hit area (under hollow shape) can be hit
Screen.Recording.2023-10-18.at.11.01.44.mov

@vercel
Copy link

vercel bot commented Oct 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 11:30am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2023 11:30am

@donteatfriedrice donteatfriedrice marked this pull request as draft October 17, 2023 15:59
@donteatfriedrice donteatfriedrice marked this pull request as ready for review October 18, 2023 06:30
@doodlewind doodlewind changed the title fix(edgeless): optimize double click to enter canvas text edit state under hollow shape feat(edgeless): optimize double click to enter canvas text edit state under hollow shape Oct 19, 2023
@doodlewind doodlewind added the notable Major improvement worth emphasizing label Oct 19, 2023
@doodlewind doodlewind mentioned this pull request Oct 19, 2023
Closed
doodlewind
doodlewind approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed improvement!

@doodlewind doodlewind merged commit 51d5c5d into toeverything:master Oct 19, 2023
19 checks passed
@donteatfriedrice donteatfriedrice deleted the fix/enter-canvas-text-edit-state branch October 26, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlewind doodlewind doodlewind approved these changes

Assignees

@donteatfriedrice donteatfriedrice

Labels
notable Major improvement worth emphasizing
Projects
AFFiNE Project
Archived in project
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double click editing doesn't work for shape inside hollow area
2 participants
@donteatfriedrice @doodlewind