Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database): incorrect tag modal position #5452

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

mingjuu
Copy link
Contributor

@mingjuu mingjuu commented Nov 26, 2023

With the screen enlarged, click the '+' plus button to cut the modal window at the top.

At that time, the value of the phase (==y) is negative.

So, when the y value is negative, I specified it as 240 to solve the truncation phenomenon.

Now, you can add tags without any inconvenience.

Thank you for giving me the opportunity to contribute.

image

Copy link

vercel bot commented Nov 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2023 3:05pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2023 3:05pm

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see your contribution, could you sign our CLA for the following review process? Thanks!

@doodlewind doodlewind changed the title fix: resolve Modal window cutting phenomenon fix: incorrect tag modal position Nov 27, 2023
@Flrande
Copy link
Member

Flrande commented Nov 27, 2023

Close #5450

@doodlewind doodlewind changed the title fix: incorrect tag modal position fix(database): incorrect tag modal position Nov 27, 2023
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@doodlewind doodlewind merged commit f54933e into toeverything:master Nov 27, 2023
20 checks passed
@Flrande Flrande mentioned this pull request Nov 27, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants