-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move edgeless page slots to edgeless page service #6180
Merged
doodlewind
merged 7 commits into
toeverything:master
from
donteatfriedrice:refactor/move-edgeless-page-slot-to-service
Feb 2, 2024
Merged
refactor: move edgeless page slots to edgeless page service #6180
doodlewind
merged 7 commits into
toeverything:master
from
donteatfriedrice:refactor/move-edgeless-page-slot-to-service
Feb 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
donteatfriedrice
commented
Feb 2, 2024
•
edited
Loading
edited
- Move edgeless page slots to edgeless page service and remove some slots.
- Move zoom related actions to service.
- Uniformly use toolManager.setEdgelessTool when changing tool types.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
donteatfriedrice
changed the title
refactor: move edgeless page slot to service
refactor: move edgeless page slots to edgeless page service
Feb 2, 2024
doodlewind
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the feat!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.