Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move edgeless page slots to edgeless page service #6180

Conversation

donteatfriedrice
Copy link
Member

@donteatfriedrice donteatfriedrice commented Feb 2, 2024

  • Move edgeless page slots to edgeless page service and remove some slots.
  • Move zoom related actions to service.
  • Uniformly use toolManager.setEdgelessTool when changing tool types.

Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 11:13am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2024 11:13am

@donteatfriedrice donteatfriedrice marked this pull request as ready for review February 2, 2024 10:33
@donteatfriedrice donteatfriedrice changed the title refactor: move edgeless page slot to service refactor: move edgeless page slots to edgeless page service Feb 2, 2024
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the feat!

@doodlewind doodlewind merged commit 9d70d32 into toeverything:master Feb 2, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notable Major improvement worth emphasizing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants