Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should not inherit last text element hasMaxWidth prop #6990

Merged
merged 1 commit into from
May 8, 2024

Conversation

donteatfriedrice
Copy link
Member

No description provided.

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 10:28am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 10:28am

Copy link

graphite-app bot commented May 8, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

graphite-app bot commented May 8, 2024

Merge activity

  • May 8, 6:00 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • May 8, 6:23 AM EDT: donteatfriedrice added this pull request to the Graphite merge queue.
  • May 8, 6:31 AM EDT: donteatfriedrice merged this pull request with the Graphite merge queue.

@donteatfriedrice donteatfriedrice force-pushed the fix/should-not-inherit-last-hasMaxWdith branch from 9d42219 to 930f56a Compare May 8, 2024 10:24
@Flrande Flrande removed the merge label May 8, 2024
@graphite-app graphite-app bot merged commit 930f56a into master May 8, 2024
19 checks passed
@graphite-app graphite-app bot deleted the fix/should-not-inherit-last-hasMaxWdith branch May 8, 2024 10:31
@Flrande
Copy link
Member

Flrande commented May 8, 2024

It seems more fundamentally to avoid this field being cached directly to solve the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants