Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(edgeless): text element issue #6991

Merged
merged 2 commits into from
May 8, 2024
Merged

fix(edgeless): text element issue #6991

merged 2 commits into from
May 8, 2024

Conversation

donteatfriedrice
Copy link
Member

@donteatfriedrice donteatfriedrice commented May 8, 2024

  • not record last text element hasMaxWidth prop in session
  • make sure edgeless text editor style box-sizing: content-box has effect

Close #6975
Close BS-215

Screen.Recording.2024-05-08.at.19.33.54.mov

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 11:18am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 11:18am

Copy link

graphite-app bot commented May 8, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

graphite-app bot commented May 8, 2024

Merge activity

  • May 8, 7:18 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • May 8, 7:21 AM EDT: donteatfriedrice added this pull request to the Graphite merge queue.

@Flrande Flrande changed the title fix: text element issue fix(edgeless): text element issue May 8, 2024
@Flrande Flrande merged commit 72fb1ba into master May 8, 2024
22 checks passed
@Flrande Flrande deleted the fix/text-element-issue branch May 8, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Text field on change, shrinks, breaks text completely​
2 participants