fix: avoid selection change when ai-panel display #7002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Your org has enabled the Graphite merge queue for merging into masterAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
donteatfriedrice
requested review from
doodlewind,
Saul-Mirone,
fundon and
Flrande
Flrande
reviewed
May 9, 2024
Flrande
approved these changes
May 9, 2024
fundon
reviewed
May 9, 2024
|
|
||
| if (this.state !== 'hidden') { | ||
| this.viewportOverlayWidget?.lock(); | ||
| } else { |
There was a problem hiding this comment.
The order can be swapped here.
!== no need.
fundon
approved these changes
May 9, 2024
pengx17
pushed a commit
to toeverything/AFFiNE
that referenced
this pull request
May 10, 2024
## Features - toeverything/blocksuite#6995 @fundon ## Bugfix - toeverything/blocksuite#7002 @donteatfriedrice - toeverything/blocksuite#7000 @regischen - toeverything/blocksuite#7001 @fundon - toeverything/blocksuite#6999 @Flrande - toeverything/blocksuite#6997 @donteatfriedrice - toeverything/blocksuite#6996 @regischen - toeverything/blocksuite#6994 @L-Sun ## Refactor ## Misc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fixed TOV-834
Before, when ai-panel opened and has generated some content, if user click or drag outside of the ai panel, the selection will be changed, then the response actions will be wired, for example, insert below or replace the wrong blocks.
Screen.Recording.2024-05-09.at.16.07.48.mov
Now can lock the viewport when ai-panel opened by calling affineViewportOverlayWidget.lock().
Screen.Recording.2024-05-09.at.16.09.21.mov