Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup block specs #7039

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

Flrande
Copy link
Member

@Flrande Flrande commented May 14, 2024

No description provided.

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 7:39am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 7:39am

Copy link

graphite-app bot commented May 14, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@doodlewind doodlewind changed the title refactor: tidy up block specs refactor: cleanup block specs May 14, 2024
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why it's needed to split paragraph-block/paragraph-spec.ts and paragraph-block/index.ts. Why not simply compose the spec in index.ts?

@doodlewind doodlewind added the notable Major improvement worth emphasizing label May 14, 2024
@Flrande
Copy link
Member Author

Flrande commented May 14, 2024

I'm not sure why it's needed to split paragraph-block/paragraph-spec.ts and paragraph-block/index.ts. Why not simply compose the spec in index.ts?

I have no particular preference for this, but some blocks may have several different specs. For example, the specs for surface in edgeless mode and page mode are different.

Copy link

graphite-app bot commented May 14, 2024

Merge activity

  • May 14, 3:33 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • May 14, 3:33 AM EDT: Saul-Mirone added this pull request to the Graphite merge queue.
  • May 14, 3:41 AM EDT: Saul-Mirone merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot merged commit 0a5a4e2 into master May 14, 2024
19 checks passed
@graphite-app graphite-app bot deleted the flrande/refactor/spec-0514 branch May 14, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge notable Major improvement worth emphasizing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants