-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: cleanup block specs #7039
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Your org has enabled the Graphite merge queue for merging into masterAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why it's needed to split paragraph-block/paragraph-spec.ts
and paragraph-block/index.ts
. Why not simply compose the spec in index.ts
?
I have no particular preference for this, but some blocks may have several different specs. For example, the specs for surface in edgeless mode and page mode are different. |
Merge activity
|
85b77ac
to
0a5a4e2
Compare
## Features - toeverything/blocksuite#7052 @donteatfriedrice ## Bugfix - toeverything/blocksuite#7072 @Flrande - toeverything/blocksuite#7073 @Flrande - toeverything/blocksuite#7062 @akumatus - toeverything/blocksuite#7066 @L-Sun - toeverything/blocksuite#7061 @Flrande - toeverything/blocksuite#7058 @L-Sun - toeverything/blocksuite#7060 @doouding - toeverything/blocksuite#7051 @L-Sun - toeverything/blocksuite#7054 @L-Sun - toeverything/blocksuite#7023 @golok727 - toeverything/blocksuite#7022 @golok727 - toeverything/blocksuite#7047 @fundon - toeverything/blocksuite#7043 @akumatus - toeverything/blocksuite#7041 @donteatfriedrice - toeverything/blocksuite#7038 @fourdim - toeverything/blocksuite#7040 @regischen ## Refactor - toeverything/blocksuite#7068 @doouding - toeverything/blocksuite#7069 @zzj3720 - toeverything/blocksuite#7065 @Flrande - toeverything/blocksuite#7048 @fundon - toeverything/blocksuite#7045 @Flrande - toeverything/blocksuite#7046 @donteatfriedrice - toeverything/blocksuite#7039 @Flrande - toeverything/blocksuite#7036 @Saul-Mirone - toeverything/blocksuite#7032 @Saul-Mirone ## Misc - toeverything/blocksuite#7063 @Saul-Mirone - toeverything/blocksuite#7050 @fourdim - toeverything/blocksuite#7044 @doouding - toeverything/blocksuite#7042 @Flrande - toeverything/blocksuite#6992 @doouding
No description provided.