Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blocks): export block spec #7061

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

Flrande
Copy link
Member

@Flrande Flrande commented May 15, 2024

No description provided.

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 7:56am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 7:56am

Copy link

graphite-app bot commented May 15, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

graphite-app bot commented May 15, 2024

Merge activity

  • May 15, 3:47 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • May 15, 3:49 AM EDT: Flrande added this pull request to the Graphite merge queue.
  • May 15, 3:57 AM EDT: Flrande merged this pull request with the Graphite merge queue.

@Flrande Flrande force-pushed the flrande/fix/export-spec-0515 branch from 0104b8a to 06cd422 Compare May 15, 2024 07:50
export * from './edgeless-specs.js';
export * from './page-specs.js';
export * from './preview-specs.js';
export * from './utils/spec-builder.js';
export * from './utils/spec-provider.js';

Copy link
Collaborator

@Saul-Mirone Saul-Mirone May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do

const commonSpec = {};
const edgelessSpec = {};

export {
  ...commonSpec,
  ...edgelessSpec
}

instead of disable eslint rules.

@graphite-app graphite-app bot merged commit 06cd422 into master May 15, 2024
19 checks passed
@graphite-app graphite-app bot deleted the flrande/fix/export-spec-0515 branch May 15, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants