Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: avoid recalculate style #7044

Merged
merged 1 commit into from
May 15, 2024

Conversation

doouding
Copy link
Member

@doouding doouding commented May 14, 2024

Change

  • Move <style> to static property to avoid style recalculation on each instance.
  • Set initial contenteditable to the inline editor container to avoid later recalculation

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 2:38am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 2:38am

Copy link

graphite-app bot commented May 14, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @doouding and the rest of your teammates on Graphite Graphite

@doodlewind doodlewind added the notable Major improvement worth emphasizing label May 14, 2024
@doouding doouding marked this pull request as ready for review May 14, 2024 09:52
@doouding doouding requested a review from Flrande as a code owner May 14, 2024 09:52
Copy link

graphite-app bot commented May 14, 2024

Merge activity

doouding added a commit that referenced this pull request May 14, 2024
### Change
- Move `<style>` to static property to avoid style recalculation on each instance.
- Set initial `contenteditable` to the inline editor container to avoid later recalculation
@doouding doouding force-pushed the 05-14-perf_avoid_recalculate_style branch from 8bc7aba to a15823e Compare May 14, 2024 13:25
@donteatfriedrice donteatfriedrice marked this pull request as draft May 14, 2024 13:31
@donteatfriedrice donteatfriedrice marked this pull request as ready for review May 15, 2024 02:30
### Change
- Move `<style>` to static property to avoid style recalculation on each instance.
- Set initial `contenteditable` to the inline editor container to avoid later recalculation
@doouding doouding force-pushed the 05-14-perf_avoid_recalculate_style branch from b1e220a to d171f76 Compare May 15, 2024 02:32
@graphite-app graphite-app bot merged commit d171f76 into master May 15, 2024
19 checks passed
@graphite-app graphite-app bot deleted the 05-14-perf_avoid_recalculate_style branch May 15, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notable Major improvement worth emphasizing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants