-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: avoid recalculate style #7044
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Your org has enabled the Graphite merge queue for merging into masterAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Flrande
reviewed
May 14, 2024
Saul-Mirone
approved these changes
May 14, 2024
Merge activity
|
doouding
added a commit
that referenced
this pull request
May 14, 2024
### Change - Move `<style>` to static property to avoid style recalculation on each instance. - Set initial `contenteditable` to the inline editor container to avoid later recalculation
doouding
force-pushed
the
05-14-perf_avoid_recalculate_style
branch
from
May 14, 2024 13:25
8bc7aba
to
a15823e
Compare
### Change - Move `<style>` to static property to avoid style recalculation on each instance. - Set initial `contenteditable` to the inline editor container to avoid later recalculation
doouding
force-pushed
the
05-14-perf_avoid_recalculate_style
branch
from
May 15, 2024 02:32
b1e220a
to
d171f76
Compare
Brooooooklyn
pushed a commit
to toeverything/AFFiNE
that referenced
this pull request
May 17, 2024
## Features - toeverything/blocksuite#7052 @donteatfriedrice ## Bugfix - toeverything/blocksuite#7072 @Flrande - toeverything/blocksuite#7073 @Flrande - toeverything/blocksuite#7062 @akumatus - toeverything/blocksuite#7066 @L-Sun - toeverything/blocksuite#7061 @Flrande - toeverything/blocksuite#7058 @L-Sun - toeverything/blocksuite#7060 @doouding - toeverything/blocksuite#7051 @L-Sun - toeverything/blocksuite#7054 @L-Sun - toeverything/blocksuite#7023 @golok727 - toeverything/blocksuite#7022 @golok727 - toeverything/blocksuite#7047 @fundon - toeverything/blocksuite#7043 @akumatus - toeverything/blocksuite#7041 @donteatfriedrice - toeverything/blocksuite#7038 @fourdim - toeverything/blocksuite#7040 @regischen ## Refactor - toeverything/blocksuite#7068 @doouding - toeverything/blocksuite#7069 @zzj3720 - toeverything/blocksuite#7065 @Flrande - toeverything/blocksuite#7048 @fundon - toeverything/blocksuite#7045 @Flrande - toeverything/blocksuite#7046 @donteatfriedrice - toeverything/blocksuite#7039 @Flrande - toeverything/blocksuite#7036 @Saul-Mirone - toeverything/blocksuite#7032 @Saul-Mirone ## Misc - toeverything/blocksuite#7063 @Saul-Mirone - toeverything/blocksuite#7050 @fourdim - toeverything/blocksuite#7044 @doouding - toeverything/blocksuite#7042 @Flrande - toeverything/blocksuite#6992 @doouding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
<style>
to static property to avoid style recalculation on each instance.contenteditable
to the inline editor container to avoid later recalculation