Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(edgeless): better rendering control using lit scheduleUpdate #7068

Conversation

doouding
Copy link
Member

@doouding doouding commented May 16, 2024

Lit allows users to override the scheduleUpdate method to change the rendering timing of elements, which is particularly suitable for rendering a large number of elements in batches to prevent blocking the main thread.

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 6:57am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 6:57am

Copy link

graphite-app bot commented May 16, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @doouding and the rest of your teammates on Graphite Graphite

@Saul-Mirone
Copy link
Collaborator

How's the performance? Does the edgeless become more smooth?

@doouding doouding requested a review from Saul-Mirone May 16, 2024 06:34
@doouding
Copy link
Member Author

How's the performance? Does the edgeless become more smooth?

No, it's just an improvement of #6992. It prevents the whole editor from sticking when there's a mass of blocks.

Copy link

graphite-app bot commented May 16, 2024

Merge activity

@doouding doouding force-pushed the 05-16-refactor_edgeless_better_rendering_control_using_lit_scheduleupdate branch from 9313a45 to a3008e5 Compare May 16, 2024 06:54
@graphite-app graphite-app bot merged commit a3008e5 into master May 16, 2024
21 checks passed
@graphite-app graphite-app bot deleted the 05-16-refactor_edgeless_better_rendering_control_using_lit_scheduleupdate branch May 16, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants