Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(edgeless): layer issue #7747

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

doouding
Copy link
Member

@doouding doouding commented Jul 29, 2024

Fixes

Fixes BS-899
Fixes BS-926
Fixes BS-966

Other changes

Added a new mechanism to sync element properties that are stored in yjs to a local map. This way, even if an element is unloaded, you can still access its properties, preventing the issue of getting undefined values in many cases.

This mechanism will migrate to use the same infra of the block in the coming iteration.

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 3:02pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2024 3:02pm

Copy link

graphite-app bot commented Jul 29, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @doouding and the rest of your teammates on Graphite Graphite

@doouding doouding temporarily deployed to Playground E2E Test July 29, 2024 04:48 — with GitHub Actions Inactive
@doouding doouding temporarily deployed to Playground E2E Test July 29, 2024 04:48 — with GitHub Actions Inactive
@doouding doouding temporarily deployed to Playground E2E Test July 29, 2024 04:48 — with GitHub Actions Inactive
@doouding doouding temporarily deployed to Playground E2E Test July 29, 2024 04:48 — with GitHub Actions Inactive
@doouding doouding temporarily deployed to Playground E2E Test July 29, 2024 04:48 — with GitHub Actions Inactive
@doouding doouding temporarily deployed to Playground E2E Test July 29, 2024 04:48 — with GitHub Actions Inactive
@doouding doouding temporarily deployed to Playground E2E Test July 29, 2024 04:48 — with GitHub Actions Inactive
@doouding doouding temporarily deployed to Playground E2E Test July 29, 2024 04:48 — with GitHub Actions Inactive
@doouding doouding temporarily deployed to Playground E2E Test July 29, 2024 04:48 — with GitHub Actions Inactive
@doouding doouding temporarily deployed to Playground E2E Test July 29, 2024 04:48 — with GitHub Actions Inactive
@doouding doouding temporarily deployed to Playground E2E Test July 29, 2024 05:25 — with GitHub Actions Inactive
@doouding doouding temporarily deployed to Playground E2E Test July 29, 2024 05:25 — with GitHub Actions Inactive
@doouding doouding temporarily deployed to Playground E2E Test July 29, 2024 05:25 — with GitHub Actions Inactive
@doouding doouding temporarily deployed to Playground E2E Test July 29, 2024 05:25 — with GitHub Actions Inactive
@doouding doouding temporarily deployed to Playground E2E Test July 29, 2024 05:25 — with GitHub Actions Inactive
@doodlewind doodlewind temporarily deployed to Playground E2E Test July 31, 2024 15:07 — with GitHub Actions Inactive
@doodlewind doodlewind temporarily deployed to Playground E2E Test July 31, 2024 15:07 — with GitHub Actions Inactive
@doodlewind doodlewind temporarily deployed to Playground E2E Test July 31, 2024 15:07 — with GitHub Actions Inactive
@doodlewind doodlewind temporarily deployed to Playground E2E Test July 31, 2024 15:07 — with GitHub Actions Inactive
@doodlewind doodlewind temporarily deployed to Playground E2E Test July 31, 2024 15:07 — with GitHub Actions Inactive
@doodlewind doodlewind temporarily deployed to Playground E2E Test July 31, 2024 15:07 — with GitHub Actions Inactive
@doodlewind doodlewind temporarily deployed to Playground E2E Test July 31, 2024 15:07 — with GitHub Actions Inactive
@doodlewind doodlewind temporarily deployed to Playground E2E Test July 31, 2024 15:07 — with GitHub Actions Inactive
@graphite-app graphite-app bot merged commit 799772d into master Jul 31, 2024
19 checks passed
@graphite-app graphite-app bot deleted the 07-29-fix_edgeless_layer_issue branch July 31, 2024 15:17
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 31, 2024 15:27 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 31, 2024 15:27 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 31, 2024 15:27 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 31, 2024 15:27 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 31, 2024 15:27 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 31, 2024 15:27 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 31, 2024 15:27 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 31, 2024 15:27 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 31, 2024 15:27 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 31, 2024 15:28 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping needed Contains workarounds that should be refactored
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants